Update trip refinement #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
requested review from
skinkie,
sgrossberndt,
herlitze and
normanoffel
skinkie
previously approved these changes
Jan 17, 2023
herlitze
reviewed
Jan 18, 2023
OJP/OJP_Trips.xsd
Outdated
| </xs:element> | ||
| <xs:element name="CheckAvailability" type="xs:boolean" minOccurs="0" default="false"> | ||
| <xs:annotation> | ||
| <xs:documentation>Checks the availability of relevant legs depending on the mode/submode. Operators or system references must be set to do this (uses OJPAvailabilityRequest indirectly)</xs:documentation> |
There was a problem hiding this comment.
Let us talk about the workflow you are expecting behind this on Friday.
There was a problem hiding this comment.
to be discussed label already added
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
0f6cda8 to
0e21b03
Compare
|
|
Use case 5.24 is adapted. 7.9 and 8.10 will have to be updated after this PR is done. I will add some more information there while finalising this PR. |
|
simpliefied a lot. So I guess we have no longer issues with it? @normanoffel @herlitze @AndreasAtSBB : Pls check, if this still fits the bill for your document. |
herlitze
reviewed
Mar 10, 2023
AndreasAtSBB
previously approved these changes
Mar 17, 2023
trurlurl
requested changes
Mar 19, 2023
OJP/OJP_JourneySupport.xsd
Outdated
| <xs:annotation> | ||
| <xs:documentation>Place within a (moving) vehicle.</xs:documentation> | ||
| <xs:documentation>Location within a (moving) vehicle.</xs:documentation> |
There was a problem hiding this comment.
Isn't that in direct contradiction to the description of TripLocationStructure, line 256?
ue71603
force-pushed
the
Update_TripRefinement
branch
from
aeb3d13 to
2114c8b
Compare
skinkie
previously approved these changes
Mar 22, 2023
ue71603
commented
Mar 23, 2023
skinkie
previously approved these changes
Apr 5, 2023
ue71603
force-pushed
the
Update_TripRefinement
branch
from
aa91e37 to
299d08b
Compare
skinkie
approved these changes
Apr 5, 2023
trurlurl
approved these changes
Apr 5, 2023
skinkie
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Malte's comment: Isn't there still a parameter missing in the TripRefine request to select a specific sharing provider when requesting a specific trip with that provider?
And some discussions I had with Andreas and André.
It is now possible to control more, what refinement should do, which system should do it.
A lot will need to be described in the specification.