Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub action to verify/lint/validate/generate documentation tables instead of Travis #274

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

sgrossberndt
Copy link
Contributor

@sgrossberndt sgrossberndt commented Dec 12, 2022

Please review this pull request urgently, this must be the next one to be merged before any other

Apparently there are security issues with the use of Travis and public logs, which lead to the exposure of the Travis token and the subsequent iteration of the public repositories for which you received emails end of last week.

GitHub revoked all my tokens due to this, which means currently Travis does not check/lint/validate/generate anything currently.

I changed the workflow to use GitHub Actions instead of Travis, made it clearer what is done by separating it into several steps and configured it to run on pull_requests and pushed to the branches "master" and "changes_for_v1.1".

@sgrossberndt sgrossberndt force-pushed the github_actions branch 8 times, most recently from 0725de7 to f6e7544 Compare December 12, 2022 11:28
@sgrossberndt sgrossberndt force-pushed the github_actions branch 3 times, most recently from 9f18e74 to 0e3b555 Compare December 12, 2022 11:38
@sgrossberndt sgrossberndt changed the title Test for GitHub actions Use GitHub action to verify/lint/validate/generate documentation tables instead of Travis Dec 12, 2022
@ue71603 ue71603 requested a review from trurlurl December 13, 2022 16:00
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. This is a great example for the other CEN repositories which are currently also being bitten occasionally due to lacking credits.

@skinkie skinkie merged commit 8660907 into changes_for_v1.1 Dec 13, 2022
@sgrossberndt sgrossberndt deleted the github_actions branch December 14, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants