Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FareProductCode to FareProductId #267

Merged
merged 8 commits into from
Jan 18, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Nov 26, 2022

Should be aligned with type

@ue71603 ue71603 added enhancement New feature or request documentation labels Nov 26, 2022
@ue71603 ue71603 added this to the v2.0 milestone Nov 26, 2022
OJP/OJP_FareSupport.xsd Outdated Show resolved Hide resolved
AndreasAtSBB
AndreasAtSBB previously approved these changes Dec 20, 2022
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed text also in the html file: Changed "FareProductCodeType" to "FareProductIdType". OK.

@ue71603 ue71603 requested a review from trurlurl December 28, 2022 16:51
trurlurl
trurlurl previously approved these changes Dec 30, 2022
Aurige
Aurige previously approved these changes Jan 10, 2023
skinkie
skinkie previously approved these changes Jan 17, 2023
# Conflicts:
#	docs/generated/index.html
@sgrossberndt sgrossberndt changed the title ID->Code for FareProduct Rename FareProductCode to FareProductId Jan 17, 2023
@sgrossberndt sgrossberndt requested a review from skinkie January 17, 2023 16:53
@sgrossberndt sgrossberndt merged commit fe7b49d into changes_for_v1.1 Jan 18, 2023
@sgrossberndt sgrossberndt deleted the FareProductCode branch January 18, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc updated enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants