Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status Service #216

Merged
merged 41 commits into from
Apr 14, 2023
Merged

Status Service #216

merged 41 commits into from
Apr 14, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Jul 20, 2022

...and major change. I guess we will have to discuss this. The input from the implementaros is certainly valued.

I used the wrong branch and have the id changes here as well, but I guess that the PR undergoes major changes anyhow.

@ue71603 ue71603 added this to the v2.0 milestone Jul 20, 2022
@ue71603
Copy link
Contributor Author

ue71603 commented Jul 20, 2022

fixes: #121

skinkie
skinkie reviewed Jul 20, 2022
View reviewed changes
OJP/OJP_Capabilities.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jul 20, 2022
View reviewed changes
OJP/OJP_Capabilities.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jul 20, 2022
View reviewed changes
OJP/OJP_Capabilities.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jul 20, 2022
View reviewed changes
OJP/OJP_Capabilities.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jul 20, 2022
View reviewed changes
OJP/OJP_Capabilities.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jul 20, 2022
View reviewed changes
OJP/OJP_Capabilities.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Jul 20, 2022
View reviewed changes
OJP/OJP_Capabilities.xsd Outdated Show resolved Hide resolved
This was referenced Jul 20, 2022
Closed
Closed
herlitze
herlitze previously requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@herlitze herlitze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for TripId and LegId should be in a separate commit.

@ue71603
Copy link
Contributor Author

ue71603 commented Jul 25, 2022

I will remove the ids. They are a problem. If the capabilities are ok for everybody, this is the final step I will take (or if there are major changes, I will do it at that time).

skinkie
skinkie reviewed Aug 8, 2022
View reviewed changes
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Aug 8, 2022
View reviewed changes
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
@Aurige
Copy link
Contributor

Aurige commented Aug 19, 2022

I don't see ServiceStarted, SystemAvailability, LastTimetableUpdate, ServerBuildVersion as capabilities, but more as Service Status

@ue71603
Copy link
Contributor Author

ue71603 commented Aug 23, 2022

Christophe:

  • Differ status from capabilities
  • The algorithm should not be implementors, but describe more, what the algorithm done.
    Matthias: Names are within, because those were variants. May switch this to profile and not algorithm

@ue71603 ue71603 changed the title Ojp capabilities - new service Ojp capabilities - new service (and also now Status Service) Aug 27, 2022
skinkie
skinkie reviewed Apr 11, 2023
View reviewed changes
OJP/OJP_Status.xsd Outdated Show resolved Hide resolved
skinkie
skinkie previously approved these changes Apr 11, 2023
View reviewed changes
skinkie
skinkie previously approved these changes Apr 11, 2023
View reviewed changes
AndreasAtSBB
AndreasAtSBB previously approved these changes Apr 12, 2023
View reviewed changes
Copy link

@AndreasAtSBB AndreasAtSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments accepted.

@ue71603 ue71603 dismissed stale reviews from AndreasAtSBB and skinkie via 9c88e4a April 14, 2023 15:08
sgrossberndt
sgrossberndt requested changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StatusProblemType is defined but not referenced (should be in the ServiceResponseContextGroup?)

sgrossberndt
sgrossberndt previously approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@sgrossberndt sgrossberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referencing is now done via <xs:element name="StatusProblemType" type="StatusProblemTypeEnumeration" substitutionGroup="ErrorType"/>

skinkie
skinkie previously approved these changes Apr 14, 2023
View reviewed changes
@sgrossberndt sgrossberndt dismissed stale reviews from skinkie and themself via c76a716 April 14, 2023 15:52
sgrossberndt and others added 2 commits April 14, 2023 17:52
@sgrossberndt
Changed StatusProblemTypeEnumeration to STATUS_INSTANCE_USAGE_DEPRECATED
c76a716 
This status is about the whole instance usage being deprecated, not the status service itself
@github-actions
Lint and update documentation tables
7689eb9
@sgrossberndt sgrossberndt merged commit 18a10a2 into changes_for_v1.1 Apr 14, 2023
@sgrossberndt sgrossberndt deleted the OJPCapabilities branch April 14, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl left review comments

@sgrossberndt sgrossberndt sgrossberndt approved these changes

@skinkie skinkie skinkie approved these changes

@AndreasAtSBB AndreasAtSBB AndreasAtSBB left review comments

@herlitze herlitze herlitze left review comments

@Aurige Aurige Aurige left review comments

@dirkweisser dirkweisser Awaiting requested review from dirkweisser

@WernerKohl WernerKohl Awaiting requested review from WernerKohl

@pvgrumbkow pvgrumbkow Awaiting requested review from pvgrumbkow

@kgrimme kgrimme Awaiting requested review from kgrimme

@DRubliMentz DRubliMentz Awaiting requested review from DRubliMentz

Assignees
No one assigned
Labels
doc updated enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ue71603 @Aurige @trurlurl @skinkie @sgrossberndt @herlitze @AndreasAtSBB