Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative Multiplicity in HTML #159

Closed
schlpbch opened this issue May 26, 2021 · 8 comments
Closed

Negative Multiplicity in HTML #159

schlpbch opened this issue May 26, 2021 · 8 comments
Assignees
Milestone

Comments

@schlpbch
Copy link

Strangely, sometimes the multiplicity are negative in the HTML generated:

NegativeMulticipliesInHTML

@jmaerki
Copy link
Contributor

jmaerki commented May 27, 2021

That's a documentation rule from the standard draft saying: "In some cases an element has to be selected from its set (XML-Choice), which is symbolised by a prefixed minus sign, e.g. "-1:1". In this case a lowercase letter, which shows a list of choices, precedes the element name. A zero in the min-value indicates an optional choice: "-0:1"."

@ue71603
Copy link
Contributor

ue71603 commented Jun 22, 2021

@schlpbch @jmaerki @skinkie
If necessary please update the issue if necessary:

From @sgrossberndt
as I wrote yesterday

#154 (comment)

the pull request must be updated.

Codewise the pull request looks fine, but Stefan mentioned that Andreas Schlapbach found some rendering issues with tables. Andreas should add an issue at https://github.com/VDVde/OJP/issues - if the mentioned issue is not #159.

@ue71603 ue71603 added this to the v2.0 milestone Apr 5, 2022
@ue71603
Copy link
Contributor

ue71603 commented Apr 22, 2022

nothing left to do for the time being.

@ue71603 ue71603 closed this as completed Apr 22, 2022
@sgrossberndt sgrossberndt reopened this Apr 25, 2022
@sgrossberndt
Copy link
Contributor

After having a look at the documentation tables at https://vdvde.github.io/OJP/generated/OJP.html#TripLegStructure once again I'd like to speak about this one again:
In my opinion the minus prefix is no longer necessary in the current layout. In the former layout it was necessary to distinguish between "normal" elements and choices. Since the current layout already makes this clear by a line "Then, the element contains one of the following elements:" above and also contains the "a","b","c",... in front of the elements:

@sgrossberndt
Copy link
Contributor

sgrossberndt commented Jun 2, 2022

Since we adhere to the SIRI layout of tables this should stay. But like #172 when hovering it should be explained in the title text what this is about. See https://www.vdv.de/431-2sdes-v-1-3.pdfx "3 Notation of XML elements and structures"

@sgrossberndt
Copy link
Contributor

Looks good. Will add a pull request.

@sgrossberndt
Copy link
Contributor

As the change is within your own repository and not available as a branch in OJP it seems I cannot create a pull request from it honoring your work, @jmaerki.

sgrossberndt added a commit that referenced this issue Oct 11, 2022
* "title" attribute with the full structure element name on references. (#172)
* "title" attribute with explanation of cardinality. (#159)

Co-authored-by: Jeremias Maerki <[email protected]>
@sgrossberndt
Copy link
Contributor

Merged in #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants