Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise cookieConsent to avoid rendering on each page transition #319

Merged
merged 4 commits into from
May 10, 2021
Merged

Optimise cookieConsent to avoid rendering on each page transition #319

merged 4 commits into from
May 10, 2021

Conversation

Vadorequest
Copy link
Member

Fixes #309

@github-actions github-actions bot temporarily deployed to customer1-staging May 10, 2021 09:57 Inactive
@Vadorequest Vadorequest mentioned this pull request May 10, 2021
Closed
@Vadorequest Vadorequest linked an issue May 10, 2021 that may be closed by this pull request
Performance issues #309
Closed
@github-actions
Copy link

✅  Deployment SUCCESS
Commit a167920 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-o2ad9ut3w-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  E2E tests SUCCESS for commit a167920 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-o2ad9ut3w-unly-oss.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review May 10, 2021 10:11
@github-actions github-actions bot temporarily deployed to customer1-staging May 10, 2021 10:13 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit dccd48c successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-914c76hdd-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  E2E tests SUCCESS for commit dccd48c previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-914c76hdd-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 10, 2021 13:54 Inactive
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 43385a5 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-8eqe6ezlv-unly-oss.vercel.app
Deployment aliased as

@github-actions github-actions bot temporarily deployed to customer1-staging May 10, 2021 14:04 Inactive
@github-actions
Copy link

✅  E2E tests SUCCESS for commit 43385a5 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-8eqe6ezlv-unly-oss.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit f673cd1 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-rb18ih1pr-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

✅  E2E tests SUCCESS for commit f673cd1 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-rb18ih1pr-unly-oss.vercel.app

@Vadorequest Vadorequest merged commit 403c87e into v2-mst-aptd-at-lcz-sty May 10, 2021
@Vadorequest Vadorequest deleted the fix-cookie-consent branch May 10, 2021 15:04
Vadorequest added a commit that referenced this pull request May 11, 2021
@Vadorequest
Optimise cookieConsent to avoid rendering on each page transition (#319)
251d6b5 
* Use useEffect to only generate DOM nodes once (instead of each page transition) - Fixes #309

* Remove "v" prefix because the NEXT_PUBLIC_APP_VERSION_RELEASE is already prefixed with "v"

* Revert changes + use a different way to avoid re-init

* Misc revert (useless changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance issues
1 participant
@Vadorequest