Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Next.js v10.2 #313

Merged
merged 7 commits into from
May 8, 2021
Merged

Upgrade to Next.js v10.2 #313

merged 7 commits into from
May 8, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 6, 2021 •
edited
Loading

Issues

  • winston was not compatible with Webpack 5 (fs module issue)
  • Custom webpack resolver had an issue which didn't matter before but made webpack 5 crash

Related: webpack/webpack#13328

Done

  • Remove winston by repplacing @unly/utils-simple-logger by @unly/simple-logger
  • Fixed custom webpack resolver

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  Deployment SUCCESS
Commit 816c5be successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-jxdef3rk2-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-c1-next-v10.vercel.app

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  Deployment SUCCESS
Commit 816c5be successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-qckg8skbu-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 6, 2021

❌  Deployment FAILED
Commit 149b635 failed to deploy to
click to see logs

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  Deployment SUCCESS
Commit 149b635 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-akfxy9ji6-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  E2E tests SUCCESS for commit 816c5be previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-jxdef3rk2-unly-oss.vercel.app

@github-actions github-actions bot had a problem deploying to customer1-staging May 6, 2021 17:36 Failure
@github-actions github-actions bot temporarily deployed to storybook May 6, 2021 17:36 Inactive
@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  E2E tests SUCCESS for commit 816c5be previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-qckg8skbu-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 6, 2021

❌  Deployment FAILED
Commit 1c1496a failed to deploy to
click to see logs

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  Deployment SUCCESS
Commit 1c1496a successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-ev9qzkp7r-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  E2E tests SUCCESS for commit 149b635 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-akfxy9ji6-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  E2E tests SUCCESS for commit 1c1496a previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-ev9qzkp7r-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 6, 2021

❌  Deployment FAILED
Commit 3ed6e66 failed to deploy to
click to see logs

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  Deployment SUCCESS
Commit 3ed6e66 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-eicy2lsk4-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 6, 2021

✅  E2E tests SUCCESS for commit 3ed6e66 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-eicy2lsk4-unly-oss.vercel.app

@Vadorequest Vadorequest linked an issue May 6, 2021 that may be closed by this pull request
Upgrade to Next v10.2 #312
Closed
@Vadorequest Vadorequest mentioned this pull request May 8, 2021
Closed
@Vadorequest
Fix webpack configuration by only adding custom env vars to the "Defi…
e9a1f4d 
…nePlugin" (they were added to "ProvidePlugin" too, by mistake)
@github-actions github-actions bot temporarily deployed to storybook May 8, 2021 09:58 Inactive
@github-actions github-actions bot had a problem deploying to customer1-staging May 8, 2021 09:58 Failure
@github-actions
Copy link

github-actions bot commented May 8, 2021

❌  Deployment FAILED
Commit e9a1f4d failed to deploy to
click to see logs

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit e9a1f4d successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-2wuw7knw5-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit e9a1f4d previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-2wuw7knw5-unly-oss.vercel.app

Vadorequest
Vadorequest commented May 8, 2021
View reviewed changes
Copy link
Member Author

@Vadorequest Vadorequest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@github-actions github-actions bot had a problem deploying to customer1-staging May 8, 2021 12:09 Failure
@github-actions
Copy link

github-actions bot commented May 8, 2021

❌  Deployment FAILED
Commit e9a1f4d failed to deploy to
click to see logs

@github-actions github-actions bot temporarily deployed to storybook May 8, 2021 12:34 Inactive
@github-actions github-actions bot had a problem deploying to customer1-staging May 8, 2021 12:34 Failure
@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 69652f3 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-k4zfte3hz-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 69652f3 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-k4zfte3hz-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 8, 2021

❌  Deployment FAILED
Commit 69652f3 failed to deploy to
click to see logs

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit e03b530 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-kggcqhspq-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit e03b530 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-kggcqhspq-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to storybook May 8, 2021 22:58 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 8, 2021 22:58 Inactive
@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 7e4d611 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-ekpyuev3d-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 7e4d611 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-fvwrqy8rl-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

@Vadorequest Vadorequest marked this pull request as ready for review May 8, 2021 23:12
@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 7e4d611 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-ekpyuev3d-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 7e4d611 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-fvwrqy8rl-unly-oss.vercel.app

@Vadorequest Vadorequest merged commit 72951d3 into v2-mst-aptd-gcms-lcz-sty May 8, 2021
@Vadorequest Vadorequest deleted the next-v10.2 branch May 8, 2021 23:13
Vadorequest added a commit that referenced this pull request May 8, 2021
@Vadorequest
Upgrade to Next.js v10.2 (#313)
7f6b187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Next v10.2
1 participant
@Vadorequest