Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GHA #180

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Improve GHA #180

merged 3 commits into from
Oct 18, 2020

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Oct 17, 2020 •
edited
Loading

Do not crash GHA when Vercel domain aliasing fails #178

@Vadorequest
Add logs for $ZEIT_DEPLOYMENT_ALIAS when deploying + make aliasing no…
b4cf6fa 
…t crash the build anymore + change way to define variables sent to $GITHUB_ENV so that they're also set for the rest of the script
@github-actions
Copy link

✅  Deployment SUCCESS
Commit b4cf6fa successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-k0knzwbw3.vercel.app
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-improve-g.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit b4cf6fa previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-k0knzwbw3.vercel.app

@github-actions
Copy link

✅  Deployment SUCCESS
Commit 131db74 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-kiqtdlh56.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-c1-improve-g.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 131db74 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-kiqtdlh56.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review October 17, 2020 19:02
@Vadorequest Vadorequest changed the title Add logs for $ZEIT_DEPLOYMENT_ALIAS when deploying + make aliasing no… Improve GHA Oct 17, 2020
@Vadorequest Vadorequest self-assigned this Oct 17, 2020
@Vadorequest
Systematically save to $GITHUB_ENV all potentially useful variables +…
8e3f49e 
… replace hardcoded config file name by dynamic using customer ref
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 8e3f49e successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-nt98oo76l.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-c1-improve-g.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit 8e3f49e previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-nt98oo76l.vercel.app

@Vadorequest Vadorequest merged commit dccc001 into v2-mst-aptd-gcms-lcz-sty Oct 18, 2020
@Vadorequest Vadorequest deleted the improve-gha branch October 18, 2020 12:25
@Vadorequest Vadorequest mentioned this pull request Oct 18, 2020
Closed
Vadorequest added a commit that referenced this pull request Oct 18, 2020
@Vadorequest
Improve GHA (#180)
f101acb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vadorequest Vadorequest

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vadorequest