Fix: Wrong expiry date check + domain without info #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Idk if there is a issue about this.
When I tried to solve this issue, I saw that maybe the PR #7 that tried to fix .br domains, was accepted even though it didn't work.
So I figure out that the problem is in the expiry date check, which does not check correctly when the variable was only initialized (in this case has a value less than 0).
Pay attention
This PR as it is, because how .br and .ua domains is trying to get expiry date. So maybe it's better to approve PR #8.
Checklist
README.md, if applicable.