Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move factory_bot_rails #100

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Move factory_bot_rails #100

merged 1 commit into from
Jan 7, 2021

Conversation

LHJE
Copy link
Collaborator

@LHJE LHJE commented Jan 7, 2021

Code Highlights:

  • This PR simply moves the factory_bot_rails gem out of the group :development, test do section into the general gem section.

Where should the reviewer start?

  • gemfile

Have Tests Been Added?

  • No.
  • Yes, but all tests are not passing.
  • Yes, and all are passing.

Any background context you want to provide?

  • This is an attempt to get factory_bot to seed the Heroku DB

Message/Questions for reviewer:

Issues:

Screenshots (if appropriate):

Tracking Consistency:

  • added appropriate labels
  • My code follows the code style of this project and has removed all unnecessary annotations
  • I have added comments on my pull request, particularly in hard-to-understand areas
  • looked at PR preview to check spelling, syntax, formatting, and completion
  • Rubocop Violations: Date.today errors, def validate(record) errors, and get_ errors

@LHJE LHJE added bug Something isn't working BEE database labels Jan 7, 2021
@LHJE LHJE added this to the Life Eras milestone Jan 7, 2021
@LHJE LHJE self-assigned this Jan 7, 2021
Copy link
Collaborator

@AngelaGuardia AngelaGuardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke! Let's see if this fixes the Heroku seeding issue.

@leahriffell leahriffell merged commit 4b8febf into main Jan 7, 2021
@leahriffell leahriffell deleted the re-seed-db branch January 7, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BEE bug Something isn't working database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants