test: refactor test-fs-read-*

* Use `common.mustNotCall()` in place of `common.noop` where appropriate * Increase specificity of regular expressions (that is, make them match the whole error string rather than part of the error string) in `assert.throws()` calls PR-URL: nodejs#13501 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Trott · Jun 8, 2017 · 7fbeeba · 7fbeeba
1 parent 6318078
commit 7fbeeba
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/test/parallel/test-fs-read-file-assert-encoding.js b/test/parallel/test-fs-read-file-assert-encoding.js
@@ -8,6 +8,6 @@ const encoding = 'foo-8';
 const filename = 'bar.txt';
 
 assert.throws(
-  fs.readFile.bind(fs, filename, { encoding }, common.noop),
-  new RegExp(`Error: Unknown encoding: ${encoding}$`)
+  fs.readFile.bind(fs, filename, { encoding }, common.mustNotCall()),
+  new RegExp(`^Error: Unknown encoding: ${encoding}$`)
 );
diff --git a/test/parallel/test-fs-read-type.js b/test/parallel/test-fs-read-type.js
@@ -13,9 +13,9 @@ assert.throws(() => {
           expected.length,
           0,
           'utf-8',
-          common.noop);
-}, /Second argument needs to be a buffer/);
+          common.mustNotCall());
+}, /^TypeError: Second argument needs to be a buffer$/);
 
 assert.throws(() => {
   fs.readSync(fd, expected.length, 0, 'utf-8');
-}, /Second argument needs to be a buffer/);
+}, /^TypeError: Second argument needs to be a buffer$/);