Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume reset issue in exoPlayer #2371

Merged
merged 1 commit into from
May 21, 2022

Conversation

justsml
Copy link
Contributor

@justsml justsml commented May 18, 2021

Fix max volume issue in exoPlayer when gaining focus.

See issue #2153

Credit: #2153 (comment)

@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you are having a similar problem, please open a new issue and reference this one instead of commenting on a stale or closed issue.

@stale stale bot added the stale Closed due to inactivity or lack or resources label Apr 19, 2022
@hueniverse hueniverse removed stale Closed due to inactivity or lack or resources ExoPlayer labels Apr 20, 2022
@hueniverse
Copy link
Contributor

@freeboub Can you do a quick review?

@freeboub
Copy link
Collaborator

Yes this is Great 👍

@MitoMonkey
Copy link

The fix works and I see it was merged in May 21, but it does not seem to be included in v5.2.x as can be seen here: https://github.com/react-native-video/react-native-video/blob/ce03223f94771153962285042f28bed8881d633c/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java#L1243

May I ask why?

@justsml
Copy link
Contributor Author

justsml commented Dec 1, 2022

It might have needed a fallback check to see if the audioVolume == 0.f then reset it to 1.f.
Not sure.

@justsml
Copy link
Contributor Author

justsml commented Dec 1, 2022

Oh, never mind, it appears lined up for the newest v6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants