-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Implementation: Recovery from transient internet failures #1448
Conversation
Merge from master to my fork
Exoplayer gradle changes
Feature implementation: Failure Retry Count
Doc changes for retry count implementation
Gradle changes reverted back
Doc modifications as per alplabetical order
updated changelog for PR 1448
@cobarx please review and merge this feature. I have tested in low bandwidth and unstable 3g/4g/wifi connections. This feature will retry and autoreconnect when the internet connects again. |
@cobarx can you please check and merge this PR |
I'm guessing this change was made to cleanup the code, however it is not functionally identical and may cause issues. Revert until those can be discussed.
Thanks for handling all the guidelines in the PR checklist, that makes my life a lot easier. I made a slight change the naming to bring it closer to what ExoPlayer calls it. I also reverted your change to the INDEX_UNSET code for video. I'm guessing based on the code that you were just trying to remove a nested if. However, it has a slight change to the behavior - if there are no groups but it's a video, it would drop into the second case. I'm not sure if that will cause problems...I spent quite a bit of time on that code and it might be necessary for it to work that way, unless you've tested it quite a bit I'd rather not risk it. |
Feature Implementation: Recovery from transient internet failures (rebased from commit 4424774)
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
Documentation updated
Update the changelog
Will update the changelog
Provide an example of how to test the change
Send failureRetryCount={10} in props. When video play is active just turn-off the internet/wifi for 1-2 seconds and turn-on immediately. Video play should continue after the wifi is turned-on
Focus the PR on only one area
ok
Describe the changes
This is a new feature to recover from transient internet issues. In mobile network the connection will not be stable and in case of transient internet issues video play should recover and continue to play once the connection is ok. Exoplayer has a feature to configure the retry count. This PR uses the exoplayer feature to recover from transient internet issues.