Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test token expiration handling with nlohmann/json traits #104

Merged
merged 9 commits into from
Oct 26, 2020
Merged

Test token expiration handling with nlohmann/json traits #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
961facd
quick pass to repro bug
prince-chrismc Oct 18, 2020
ff0db59
handling both signed/unsigned type of nlohmann/json
prince-chrismc Oct 18, 2020
7f3dcf1
cleanup test
prince-chrismc Oct 18, 2020
400b7f7
keeping example inline with test code
prince-chrismc Oct 18, 2020
531fd88
adding test for expired token
prince-chrismc Oct 18, 2020
dfc5b70
checking error_code on expired
prince-chrismc Oct 18, 2020
1c69c2b
fix typo
prince-chrismc Oct 18, 2020
ddb7ec1
Merge branch 'master' into bug-jwt-103
prince-chrismc Oct 18, 2020
5f03a18
Merge branch 'master' into bug-jwt-103
Thalhammer Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions example/private-claims.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ std::string make_nlohmann_token() {
return type::boolean;
else if (val.type() == json::value_t::number_integer)
return type::integer;
else if (val.type() == json::value_t::number_unsigned) // nlohmann internally tracks two types of integers
return type::integer;
else if (val.type() == json::value_t::number_float)
return type::number;
else if (val.type() == json::value_t::string)
Expand Down Expand Up @@ -85,9 +87,14 @@ std::string make_nlohmann_token() {
}

static int64_t as_int(const json &val) {
if (val.type() != json::value_t::number_integer)
switch(val.type())
{
case json::value_t::number_integer:
case json::value_t::number_unsigned:
return val.get<int64_t>();
default:
throw std::bad_cast();
return val.get<int64_t>();
}
}

static bool as_bool(const json &val) {
Expand Down Expand Up @@ -149,4 +156,4 @@ int main(int argc, const char **argv) {
const auto api_array =
decoded.get_payload_claims()["object"].to_json().get("api").get("array");
std::cout << "api array = " << api_array << std::endl;
}
}
56 changes: 49 additions & 7 deletions tests/NlohmannTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,20 @@ struct nlohmann_traits {
using value_type = json;
using object_type = json::object_t;
using array_type = json::array_t;
using string_type = std::string;
using number_type = double;
using integer_type = int64_t;
using boolean_type = bool;

using string_type = std::string; // current limitation of traits implementation
using number_type = json::number_float_t;
using integer_type = json::number_integer_t;
using boolean_type = json::boolean_t;
static jwt::json::type get_type(const json &val) {
using jwt::json::type;

if (val.type() == json::value_t::boolean)
return type::boolean;
else if (val.type() == json::value_t::number_integer)
return type::integer;
else if (val.type() == json::value_t::number_unsigned) // nlohmann internally tracks two types of integers
return type::integer;
else if (val.type() == json::value_t::number_float)
return type::number;
else if (val.type() == json::value_t::string)
Expand Down Expand Up @@ -52,9 +54,14 @@ struct nlohmann_traits {
}

static int64_t as_int(const json &val) {
if (val.type() != json::value_t::number_integer)
switch(val.type())
{
case json::value_t::number_integer:
case json::value_t::number_unsigned:
return val.get<int64_t>();
default:
throw std::bad_cast();
return val.get<int64_t>();
}
}

static bool as_bool(const json &val) {
Expand Down Expand Up @@ -147,3 +154,38 @@ TEST(NlohmannTest, VerifyTokenHS256) {
auto decoded_token = jwt::decode<nlohmann_traits>(token);
verify.verify(decoded_token);
}

TEST(NlohmannTest, VerifyTokenExpirationValid) {
const auto token = jwt::create<nlohmann_traits>()
.set_issuer("auth0")
.set_issued_at(std::chrono::system_clock::now())
.set_expires_at(std::chrono::system_clock::now() + std::chrono::seconds{3600})
.sign(jwt::algorithm::hs256{"secret"});

auto verify = jwt::verify<jwt::default_clock, nlohmann_traits>({})
.allow_algorithm(jwt::algorithm::hs256{ "secret" })
.with_issuer("auth0");

auto decoded_token = jwt::decode<nlohmann_traits>(token);
verify.verify(decoded_token);
}

TEST(NlohmannTest, VerifyTokenExpired) {
const auto token = jwt::create<nlohmann_traits>()
.set_issuer("auth0")
.set_issued_at(std::chrono::system_clock::now() - std::chrono::seconds{3601})
.set_expires_at(std::chrono::system_clock::now() - std::chrono::seconds{1})
.sign(jwt::algorithm::hs256{"secret"});

auto verify = jwt::verify<jwt::default_clock, nlohmann_traits>({})
.allow_algorithm(jwt::algorithm::hs256{ "secret" })
.with_issuer("auth0");

auto decoded_token = jwt::decode<nlohmann_traits>(token);
ASSERT_THROW(verify.verify(decoded_token), jwt::token_verification_exception);
std::error_code ec;
ASSERT_NO_THROW(verify.verify(decoded_token, ec));
ASSERT_TRUE(!(!ec));
ASSERT_EQ(ec.category(), jwt::error::token_verification_error_category());
ASSERT_EQ(ec.value(), static_cast<int>(jwt::error::token_verification_error::token_expired));
}