Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export icons workflow #318

Open
wants to merge 17 commits into
base: production
Choose a base branch
from
Open

Fix export icons workflow #318

wants to merge 17 commits into from

Conversation

yceballost
Copy link
Collaborator

@yceballost yceballost commented Jan 9, 2025

I remove qpdf --replace-input --deterministic-id $i line because is generating PDFs errors by some reason.

That line that I removed helped to avoid generating many changes in the PRs when exporting the pdfs. This PR is a quick fix but it's probably that we will have 3K of changes in the next PR. (All pdf files generated again and overwritten)

Error in workflow

icons/o2/regular/football-ball-regular.pdf
WARNING: icons/o2/regular/football-ball-regular.pdf: object 10/0 has unexpected xref entry type
qpdf: there are warnings; original file kept in icons/o2/regular/football-ball-regular.pdf.~qpdf-orig
qpdf: operation succeeded with warnings; resulting file may have some problems
Error: Process completed with exit code 3.

Old pdf in repo:

yayo@Yayos-iMac icons % qpdf --check --show-xref o2/regular/football-ball-regular.pdf
checking o2/regular/football-ball-regular.pdf
PDF Version: 1.5
File is not encrypted
File is not linearized
No syntax or stream encoding errors found; the file may still contain
errors that qpdf cannot detect
1/0: uncompressed; offset = 15
2/0: uncompressed; offset = 64
3/0: uncompressed; offset = 123
4/0: uncompressed; offset = 293
5/0: uncompressed; offset = 961

Same pdf exported from Figma

yayo@Yayos-iMac icons % qpdf --check --show-xref o2/regular/football-ball-regular.pdf
checking o2/regular/football-ball-regular.pdf
PDF Version: 1.7
File is not encrypted
File is not linearized
No syntax or stream encoding errors found; the file may still contain
errors that qpdf cannot detect
1/0: uncompressed; offset = 10
2/0: uncompressed; offset = 2697
3/0: uncompressed; offset = 2720
4/0: uncompressed; offset = 2758
5/0: uncompressed; offset = 2810
6/0: uncompressed; offset = 3859
7/0: uncompressed; offset = 3881
8/0: uncompressed; offset = 4054
9/0: uncompressed; offset = 4128

@yceballost yceballost requested a review from aweell January 9, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants