-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need a way of deploying this to deploy this. Based on https://bitbucket.org/r8szq0vy/theolive-player/src/master/web/demo/scripts/deploy.ts you could make a github action.
Do we want to deploy from here or from our internal repo? I removed the steps and the deploy scripts assuming we'd want to keep deployments from the internal repo but I'm ok to do it either way. |
I would do it here and fully remove all demo code from the old repo once this is merged. Make sure that all data that should not be publicly visible to be inside secrets. |
Easy, I've added a basic deployment script now, which will deploy on merge to |
onMount(() => { | ||
if (!browser) return | ||
const searchParams = new URLSearchParams(window.location.search) | ||
channelId = searchParams.get('channel') ?? undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not updated when the goto triggers. (you can reproduce this by navigating to http://localhost:5173, it will always have channelId undefined)
background: black; | ||
margin: 0; | ||
padding: 0; | ||
height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a duplicate
|
||
<style> | ||
.container { | ||
background-color: rgba(255, 255, 255, 0.15); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the video is white, all the labels become invisible (you can fix this by using background-color: rgba(0, 0, 0, 0.5);)
border-radius: 4px; | ||
z-index: 1001; | ||
left: 0 !important; | ||
background-color: rgba(255, 255, 255, 0.1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one also becomes invisible on a white video, you could change it to background-color: rgba(0, 0, 0, 0.3);
No description provided.