Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(quic): remove x509 cert workaround in favor of openssl calls #488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rexicon226
Copy link
Contributor

@Rexicon226 Rexicon226 commented Jan 10, 2025

Agave does a hack where it precomputes the bytes of the certificate and public key because rustls doesn't support, something. I didn't exactly understand what it doesn't support.

I originally just copied straight from what agave was doing under the time pressure from the demo, however, now we can take a step back and fix up some of the uglier parts of the quic client. We're not using rustls, so we can confidently use the cleaner approach of constructing the certificate and keys using the boringssl API.

After a bit of fiddling around with the proper settings and realizing that X509_gmtime_adj returns an error if the value passed in is too large, this branch passes the transaction sender test and general usage by me.

@Rexicon226 Rexicon226 requested a review from yewman January 10, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

1 participant