Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gossip): consistent scope + less alerts #484

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(gossip): consistent scope + less alerts #484

merged 1 commit into from
Jan 9, 2025

Conversation

0xNineteen
Copy link
Contributor

@0xNineteen 0xNineteen commented Jan 8, 2025 •
edited
Loading

  • make all gossip logs use the same scope (prev was different which means we werent tracking all error logs in grafana using filtering by scope)
  • remove no data alerts using 'noDataState: KeepLast' in the alert rules (this was prev causing slack spams with incorrect values)
  • add warning logs to grafana dashboard (realized well also want to see these)

@0xNineteen Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0xNineteen 0xNineteen marked this pull request as ready for review January 8, 2025 16:15
@0xNineteen 0xNineteen marked this pull request as draft January 8, 2025 16:15
@0xNineteen 0xNineteen force-pushed the 01-08-fix_gossip_consistent_scope_less_alerts branch from 617baf4 to 6e23a86 Compare January 8, 2025 19:39
@0xNineteen 0xNineteen requested a review from Sobeston January 8, 2025 21:03
@0xNineteen 0xNineteen marked this pull request as ready for review January 8, 2025 21:03
@0xNineteen 0xNineteen enabled auto-merge (squash) January 8, 2025 21:03
@0xNineteen 0xNineteen self-assigned this Jan 8, 2025
Sobeston
Sobeston approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Sobeston Sobeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@0xNineteen 0xNineteen merged commit 3c6d049 into main Jan 9, 2025
8 checks passed
@0xNineteen 0xNineteen deleted the 01-08-fix_gossip_consistent_scope_less_alerts branch January 9, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sobeston Sobeston Sobeston approved these changes

Assignees

@0xNineteen 0xNineteen

Labels
None yet
Projects
Sig
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xNineteen @Sobeston