Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(shred-network): reduce gossip lock hold time #460

Merged
merged 3 commits into from
Dec 20, 2024
Merged

perf(shred-network): reduce gossip lock hold time #460

merged 3 commits into from
Dec 20, 2024

Conversation

dnut
Copy link
Contributor

@dnut dnut commented Dec 19, 2024 •
edited
Loading

Previously the gossip table lock was held for the entire function. It's only needed for this initial operation though.

@dnut dnut requested a review from yewman December 19, 2024 11:55
@dnut dnut marked this pull request as ready for review December 19, 2024 11:55
@dnut dnut enabled auto-merge (squash) December 19, 2024 11:55
yewman
yewman approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@yewman yewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dnut dnut merged commit 1e0a16d into main Dec 20, 2024
8 checks passed
@dnut dnut deleted the dnut/perf/shred-network/reduce-gossip-lock branch December 20, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yewman yewman yewman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sig
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnut @yewman