Fixes multiple problems in last-modified handling #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vbfox
commented
Sep 26, 2018
vbfox
commented
- The header value wasn't in GMT (It was the time on the current server timezone with 'GMT' written after)
- On filesystems with millisecond precision times in fstat a 304 was never returned as the header value is only precise to the second. (All recent linux FS and windows NTFS are in this case)
- Last accessed time was used instead of last modified
* The header value wasn't in GMT * On filesystems with millisecond precision times in fstat 304 was never returned * Last accessed time was used instead of last modified
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.