Always call StreamChatCompletionSubscriber.onComplete()

StefanBratanov · Mar 15, 2024 · 9dbd59b · 9dbd59b
1 parent f148979
commit 9dbd59b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/main/java/io/github/stefanbratanov/jvm/openai/ChatClient.java b/src/main/java/io/github/stefanbratanov/jvm/openai/ChatClient.java
@@ -80,9 +80,8 @@ public void streamChatCompletion(
             (__, ex) -> {
               if (ex != null) {
                 subscriber.onException(ex);
-              } else {
-                subscriber.onComplete();
               }
+              subscriber.onComplete();
             });
   }
 

diff --git a/src/main/java/io/github/stefanbratanov/jvm/openai/StreamChatCompletionSubscriber.java b/src/main/java/io/github/stefanbratanov/jvm/openai/StreamChatCompletionSubscriber.java
@@ -9,6 +9,6 @@ public interface StreamChatCompletionSubscriber {
   /** Will be called if any exception happens while processing * */
   void onException(Throwable ex);
 
-  /** Will be called when the stream is complete */
+  /** Will be called when the stream is complete or an exception has happened */
   void onComplete();
 }