-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit README and Dockerfile #34
Conversation
Hi. I remove useless file entrypoint.sh and implemented python file launch by pointing to python root. fixed the structure inside the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I have a few requested changes + discussion points. But I feel like this will help in a few ways, especially with the time needed to run the action.
README.md
Outdated
## Versions | ||
|
||
Please use this version of your action config file: | ||
|
||
* `SpicyPizza/create-envfile@master` | ||
|
||
* `SpicyPizza/[email protected]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this section makes sense. Do you mean to suggest that people should choose one of them to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, this item i added to just to show the current working versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a commit to make it more verbose 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more item, then I'll do the commit myself with some changes 👍
2cb33a0
to
2a5eab1
Compare
I call you one more time to review. Everything that was discussed here was corrected. If something else, then I'm waiting feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes!
|
||
jobs: | ||
|
||
create-envfile: | ||
|
||
runs-on: ubuntu-18.04 | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Care to elaborate?
Hi. I remove useless file entrypoint.sh and implemented python file launch by pointing to python root. fixed the structure inside the container.