-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for PR #6638 - typos and grammar #6673
Conversation
Including resolved merge conflicts.
How do you detect those missed ones? The "gripe" I have with the (inconsistent) line breaks is that it makes it tricky to search across files for the substring/phrase of words which contains the typo word. |
I can't figure out how to make gettext to generate consistent line breaks on different machines.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
I was actually still busy keeping gettexty happy. It moved a bunch of translations to the comment section. e.g. from your last translations commit: Do I have to make a seperate PR for that? I've been running it al along with '-full', one '-'. 😫 |
Including a marathon of resolving merge conflicts due to PRs today.
We should abolish multi-line msgids :-)
Description
This looks like a huge PR, but it is only fixes for typos and grammar.
On the previous PR #6638 I mistakenly used _en.po as the reference instead of the .pot.
It caused missed strings in the source and other .po files.
This around I triple checked again to make sure the msgids are in sync with the L"" strings in the code.
Comments, variable names and non-English translation strings were excluded.
I learnt that typos were "fixed" before by using translations. After this PR, those translations are no longer relevant and can be cleaned up.
Hopefully this sets a new baseline which will last us a while. :-)
Screenshots/Recordings/Graphs
Tests
The code compiled and ran successfully.
The translation files were verified with ./run_gettext.sh
I did not se any issues when running ./run_gettext.sh --full
Please confirm it again, before the merge.