Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles for Kingroon KLP1 and KP3S V1 #6554

Merged

Conversation

kennethjiang
Copy link
Contributor

Description

This PR is to add the profiles for Kingroon KLP1 and KP3S V1 printers.

Screenshots/Recordings/Graphs

Screenshot 2024-08-20 at 4 54 43 PM

Tests

Rebuild the project. And add the new printer models to verify the associated filaments and process files are correctly loaded.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kenneth

Can you check the errors reported by the CICD validation tool?

@Gudzonskiy
Copy link
Contributor

Gudzonskiy commented Aug 26, 2024

Add KP5L-klipper! Where should I put the profile folder?
KP5L.zip

@kennethjiang
Copy link
Contributor Author

Hi Kenneth

Can you check the errors reported by the CICD validation tool?

Sorry for the delay. will do soon.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@SoftFever SoftFever merged commit c30ffb1 into SoftFever:main Aug 27, 2024
1 check passed
@Gudzonskiy
Copy link
Contributor

KP5L.zip

@2greatsecret
Copy link

2greatsecret commented Oct 30, 2024

The specified profile is the KLP1 (230) version, which is why the printable_area does not match for the KLP1 (210). There should definitely be two distinct profiles for the KLP1: KLP1 (210) and KLP1 (230), as clearly designated by the manufacturer.
Could the differences in the extruder also play a role?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants