Fix crash in printer config when switching tabs #6537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some explainations: This PR updates the tab buttons in place and avoid destroying buttons when unnecessary. |
Noisyfox
commented
Aug 23, 2024
| @@ -470,7 +470,7 @@ void PartPlate::calc_gridlines(const ExPolygon& poly, const BoundingBox& pp_bbox | |||
| int count = 0; | |||
| int step = 10; | |||
| // Orca: use 500 x 500 bed size as baseline. | |||
| auto grid_counts = pp_bbox.size() / ((coord_t) scale_(step * 50)); | |||
| const Point grid_counts = pp_bbox.size() / ((coord_t) scale_(step * 50)); | |||
There was a problem hiding this comment.
This line caused false address sanitizer exceptions that prevented me from debugging the real poblem so I fixed this. Isn't really related to the crash though.
SoftFever
approved these changes
Aug 23, 2024
3 tasks
Merged
henrivdr
pushed a commit
to henrivdr/OrcaSlicer
that referenced
this pull request
Aug 27, 2024
* Fix ASAN with MSVC * Make ASAN happy * Avoid deleting activated tab button by not calling `DeleteAllItems` (#SoftFever#6486)
henrivdr
pushed a commit
to henrivdr/OrcaSlicer
that referenced
this pull request
Sep 2, 2024
* Fix ASAN with MSVC * Make ASAN happy * Avoid deleting activated tab button by not calling `DeleteAllItems` (#SoftFever#6486)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6486