Another outline algorithm based on depth buffer

[Noisyfox]

Based on the algorithm by leoneruggiero: https://www.shadertoy.com/view/DslXz2

Still not perfect. might combine a normal based edge detection algorithm and try the Sobel kernel too.

And I'll add a preference option to disable this too. Now there is an option in the View menu to toggle this on & off. It's off by default for now, as it's still experimental.

[discip]

I'm surprised you're still working on this. 😃

Unfortunately, under Linux (Manjaro) some artifacts occur when either the mouse or the object is moved.

[Noisyfox]

Sigh... this doesn't work on macOS... Gonna use a different approach then.

[discip]

That's unfortunate. 😔
It seemed very promising.

[discip]

I'm not sure if this should solve the reported issue, but unfortunately, that behavior persists after 70495a3.

[kylek29]

I like it, I know you're looking for a solution that works across all OS builds, but maybe add it as an experimental?

It's so hard to edit text in some scenarios because it vanishes into the surrounding model. Ideally, this would be a toggle in the View drop-down (or hotkey, etc.).

[Noisyfox]

I'm surprised you're still working on this. 😃

Unfortunately, under Linux (Manjaro) some artifacts occur when either the mouse or the object is moved.

Are you using the Manjaro GNOME version？

[Noisyfox]

Currently Orca uses OpenGL 2.0 on macOS, which is quite outdated and lack of some new features, and I guess it has some thing to do with this outline not working too.

Apple does support OpenGL 4.1 on macOS, but with core profile only. Unfortunately Orca currently requires OpenGL 4.1 compatibility profile because it uses some fixed pipeline draw calls such as glPopAttrib and glLineWidth etc, which will have to be replaced by shaders. I plan to do this in a separate branch instead of squeezing everything into this PR.

As for now, I will add an option in preference (or the view menu) to turn this outline on & off (in case it causes any articats/performance issues) and get this merged first, then dealing with issues such as macOS compatibility and artifacts on some Linux distos.

[discip]

Are you using the Manjaro GNOME version？

Sorry, I missed your question.
Yes, it's GNOME.

[Noisyfox]

Are you using the Manjaro GNOME version？

Sorry, I missed your question. Yes, it's GNOME.

I installed it in VMware but unfortunately I couldn't reproduce this issue. This might have something to do with the gpu driver I think.

[discip]

Just in case this would be of any help.
Here is my setup:

System Details Report

---

Report details

• Date generated: 2024-08-31 03:02:11

Hardware Information:

• Hardware Model: ASUS ROG STRIX X670E-E GAMING WIFI
• Memory: 32,0 GiB
• Processor: AMD Ryzen™ 9 7950X3D × 32
• Graphics: AMD Radeon™ RX 7900 XTX
• Disk Capacity: 2,0 TB

Software Information:

• Firmware Version: 2007
• OS Name: Manjaro Linux
• OS Build: rolling
• OS Type: 64-bit
• GNOME Version: 46
• Windowing System: Wayland
• Kernel Version: Linux 6.8.12-3-MANJARO

[Noisyfox]

Maybe some AMD driver issue? Idk...

[Noisyfox]

Good news. After using OpenGL 4.1 on macOS the outline works properly now.
Any masOS users that are interested in this could try the PR #6622

[SoftFever]

LGTM
Thank you