Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap fill tool tip clarification & filter_out_gap_fill setting visibility #6468

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Aug 15, 2024

Description

Clarified the gap fill selection drop down tool tip.

fixes: #6467

Edit:
Following feedback, the tooltip of filter_out_gap_fill is also amended for clarity as well as the setting not being hidden any more if None is selected on the apply gap fill option, as this also controls the classic wall generator gap fill filter.

@igiannakas igiannakas changed the title Gap fill tool tip clarification Gap fill tool tip clarification & filter_out_gap_fill setting visibility Aug 16, 2024
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@SoftFever SoftFever merged commit 01b1681 into SoftFever:main Aug 18, 2024
15 checks passed
henrivdr pushed a commit to henrivdr/OrcaSlicer that referenced this pull request Sep 2, 2024
…ity (SoftFever#6468)

* Gap fill tool tip clarification

* Gap fill text and parameter visibility update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Apply Gap Fill" Setting Not Functioning as Expected
2 participants