Fix crash on Linux when switching between tabs in printer config #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noisyfox
force-pushed
the
bugfox/linux-crash
branch
from
8ab92ed to
aee9f1a
Compare
3 tasks
Noisyfox
force-pushed
the
bugfox/linux-crash
branch
from
aee9f1a to
41fca66
Compare
Noisyfox
force-pushed
the
bugfox/linux-crash
branch
from
41fca66 to
d126e1c
Compare
discip
approved these changes
Aug 13, 2024
SoftFever
reviewed
Aug 18, 2024
SoftFever
reviewed
Aug 18, 2024
| @@ -506,6 +506,7 @@ class PointCtrl : public Field { | |||
| TextInput* x_input{nullptr}; | |||
| TextInput* y_input{nullptr}; | |||
|
|
|||
| wxWindow* window{nullptr}; | |||
|
Thank you |
henrivdr
pushed a commit
to henrivdr/OrcaSlicer
that referenced
this pull request
Aug 27, 2024
…tFever#6437) * Fix crash due to the wrong window get returned in `PointCtrl` (SoftFever#6261). `getWindow()` must return the control itself, not its child control; otherwise the child control will be destroyed twice when the tab container is destroyed. * Fix another crash on Linux caused by unused undo button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6261.