Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z hop performed after retraction in PA pattern calibration. Fix z hop config value not used #6245

Merged

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Jul 25, 2024

Description

Fix z hop performed after retraction in PA pattern calibration. Fix z hop extruder config value not used

Fixes #6232

Screenshots:

0.4 z hop
image

0 zhop
image

Tests

Checked with a z hop value set in the extruder. Z hop operations performed correctly (with the right height) and after the retraction operation.
Checked restoring of z height after the travel move. Works ok. Checked de-retraction after travel move. Works OK
Checked with a 0 z hop height in the extruder section. Works ok (no z hop performed).

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@SoftFever SoftFever merged commit dcabdb8 into SoftFever:main Aug 6, 2024
14 of 15 checks passed
@igiannakas igiannakas deleted the Fix-Z-Hop-in-PA-pattern-calibration branch August 6, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CalibPressureAdvancePattern does z-hop before retraction, z-hop cannot be adjusted or disabled
2 participants