fix gizmo bar wobbling #6230
fix gizmo bar wobbling #6230
Conversation
Gizmo bar is wobbling at specific application window width range.
This comes from a bar scaling calculations method:
- new scale calculated for already scaled bar
- scale stored as application settings loosing precision
Rework gizmo bar resizing code to remove feedback:
- calculate scale factor based on unscaled bar size
|
i saw many linux users complain about this on discord and reddit. maybe more testers needed |
|
I've had a similar issue on MacOS. Will test this, thank you for the effort in fixing it!!! |
|
It works but on Mac OS it makes the bar too small:
|
|
@igiannakas , thanks for your testing @yw4z, thanks for your comment. Looking at your changes I see that windows builds are still broken. I'll update PR once fix MacOS and Windows builds. |
Unify scaling implementation across platforms (MacOS, Win, Linux). Now all platform scale bar setting icon size. Toolbar scale is used for high-DPI displays scaling only.
|
Upon code studying I found that #4552 only affects windows build. After that I've installed windows test VM, download Orca release bulid and found that gizmo bar icons are slightly smaller and much sharper:
Gizmo bar scaling code now unified across all platforms and shall produce exact result across all three. |
|
Tested on MacOS - think its working well! |
src/slic3r/GUI/GLCanvas3D.cpp
Outdated
| collapse_toolbar.set_scale(sc / 2.0); | ||
| size *= m_retina_helper->get_scale_factor(); | ||
|
|
||
| /* Soolbar scale is a constant value which depends on display resolution and OS. */ |
There was a problem hiding this comment.
Could you add a prefex Orca: for the comments?
So that it's will make my future work of merging upstreams easier
|
Added commentary. Slightly reorganized code to minimize diff output. |
Description
Gizmo bar is wobbling at specific application window width range. This comes from a bar scaling calculations method:
- new scale calculated for already scaled bar
- scale stored as application settings loosing precision
Rework gizmo bar resizing code to remove feedback:
- calculate scale factor based on unscaled bar size
Screenshots/Recordings/Graphs
Screen recording demonstrating the problem
orca-gizmo-bar-report.mp4
Tests
Manual tests with different window sizes