Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access violation when slicing project with print-by-object mode #5984

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Jul 2, 2024

Slice will fail if:

  1. support is enabled
  2. object is floating (by having a very sharp edge touching the build plate)
  3. print-by-object
  4. Only a single filament is used

This project demonstrate this issue:
toolorderissue.3mf.txt

The same issue was presented in by-layer mode and was patched by this commit before: 612204b
And this PR applies this same patch to by-object mode.

…cing when print-by-object mode is used.

This applys the same fix as 612204b
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you!

@SoftFever SoftFever merged commit 783570e into SoftFever:main Jul 30, 2024
15 checks passed
@Noisyfox Noisyfox deleted the bugfox/by-object-floating branch July 31, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants