-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use one loop for draft shield #5786
Conversation
5a80975
to
d5d54df
Compare
47f61f6
to
cafdac0
Compare
THANK YOU!! I was busting my head on how to do the same when I enabled the feature and could not figure it out no matter what I tried! So I gave up :) That is a nice and simple fix! Well done for this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you!
Hi @SoftFever , I put attention that Limited Draft Shield value actually has no meaning, as skirt is the same anyway. But before this PR skirt/shield has Skirt loops loops for Limited/Disabled and now it's one loop in both cases: Question is whether one need tall multiloop skirt/shield? What do you think? |
Actually Draft Shield parameter also becomes excessive, one may just set skirt height to big enough value. |
I’d keep the draft shield as not all users relate to this as a work around. Plus it’s automatic in its height vs trying to calculate it manually. Prusa has this available so for consistency between slicers I’d suggest it’s retained. For draft shield you don’t need many loops to be honest. One can make the argument that a one wall draft shield is weaker and may crack, but so will a multi wall one, so I’d say just just keep one option - enable draft shield and you’re done. I think 😀 |
It warps, not cracks. but still glued to the base. Multiple walls produce stronger detaching force.
So just OFF and ON. I agree. I'm preparing PR for object skirt/shield, so I will also remove "Limited" option. |
Currently draft shield loops number is set by skirt loops option. If it's set to one
there is a high chance it will be disconnected because of shield warping. If it's set to several loops
there is a lot of time and material waste (and probably adhesion is also affecting by thick wall warping).
This PR sets draft shield to one loop:
thus combining good bed adhesion and draft protection.
Actually draft shield loops number could be configurable, but from my extensive usage of draft shield with materials like ABS/ASA it's not necessary. Three-five first layer loops and one loop shield works very good.