Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple filament minimum print speed from overhang slowdown #3859

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/libslic3r/GCode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4975,7 +4975,6 @@ std::string GCode::_extrude(const ExtrusionPath &path, std::string description,

double e_per_mm = m_writer.extruder()->e_per_mm3() * _mm3_per_mm;

double min_speed = double(m_config.slow_down_min_speed.get_at(m_writer.extruder()->id()));
// set speed
if (speed == -1) {
int overhang_degree = path.get_overhang_degree();
Expand Down Expand Up @@ -5361,7 +5360,7 @@ std::string GCode::_extrude(const ExtrusionPath &path, std::string description,
}
}
} else {
double last_set_speed = std::max((float)EXTRUDER_CONFIG(slow_down_min_speed), new_points[0].speed) * 60.0;
double last_set_speed = new_points[0].speed * 60.0;

gcode += m_writer.set_speed(last_set_speed, "", comment);
Vec2d prev = this->point_to_gcode_quantized(new_points[0].p);
Expand Down Expand Up @@ -5405,7 +5404,7 @@ std::string GCode::_extrude(const ExtrusionPath &path, std::string description,
}

const double line_length = (p - prev).norm();
double new_speed = std::max((float)EXTRUDER_CONFIG(slow_down_min_speed), pre_processed_point.speed) * 60.0;
double new_speed = pre_processed_point.speed * 60.0;
if (last_set_speed != new_speed) {
gcode += m_writer.set_speed(new_speed, "", comment);
last_set_speed = new_speed;
Expand Down
3 changes: 2 additions & 1 deletion src/libslic3r/PrintConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2941,7 +2941,8 @@ def = this->add("filament_loading_speed", coFloats);

def = this->add("slow_down_min_speed", coFloats);
def->label = L("Min print speed");
def->tooltip = L("The minimum printing speed for the filament when slow down for better layer cooling is enabled, when printing overhangs and when feature speeds are not specified explicitly.");
def->tooltip = L("The minimum printing speed that the printer will slow down to to attempt to maintain the minimum layer time "
"above, when slow down for better layer cooling is enabled.");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.
It expain the parameter more precisely now.

def->sidetext = L("mm/s");
def->min = 0;
def->mode = comAdvanced;
Expand Down
Loading