allow document.asset.copyright to be an empty string #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting
document.asset.copyright
in voyager-story makes for a document that fails to validate :document.asset.copyright
has aminLength
of 1 but is optional indocument.schema.json
Both are reasonable, but can't work together.
At first I thought about saving
copyright
only when not empty but then Voyager will always revert back to the default Smithsonian notice on reload (and then will write it on next save), which is not ideal.So I removed the minLength requirement and marked the property as required to reflect the behavior.