-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sitecore-jss-dev-tools][sitecore-jss-cli] Replace old and security vulnerable 'request' NPM package with axios
#541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Think we need to upgrade the other packages' axios versions (see comment), but otherwise just a couple other minor comments.
Hey @illiakovalenko! Can you confirm that this will work with Edit: We realized later that this environment variable can't be set with dotenv anyway. I know it's not technically in scope of this, but could we potentially add our own environment variable for configuring the https://medium.com/@jamomani/adding-trusted-ca-to-node-client-with-axios-2792024bca4 Edit again: Nevermind, let's take care of this elsewhere so you can merge. |
Description
request
byaxios
package-deploy.ts
Motivation
How Has This Been Tested?
Types of changes
/docs
directory)Checklist: