Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub method discovery includes methods it shouldn't #1443

Closed
DamianEdwards opened this issue Jan 29, 2013 · 1 comment
Closed

Hub method discovery includes methods it shouldn't #1443

DamianEdwards opened this issue Jan 29, 2013 · 1 comment
Assignees
@davidfowl
Labels
security type: Bug
Milestone
1.0 RTW

Comments

@DamianEdwards
Copy link
Member

ReflectionHelper.GetExportedHubMethods allows unintended methods to be called. There are two issues: (a) it uses a blacklist approach instead of a whitelist approach [which forgets about things like events], and (b) it does not account for virtual overrides. Look at MVC’s ActionMethodSelector for inspiration.
@ghost ghost assigned davidfowl Jan 29, 2013
davidfowl added a commit that referenced this issue Jan 29, 2013
@davidfowl
Don't expose certain methods on hub methods.
97b9adc 
- Don't expose methods on object or events.
- Added unit tests.
#1443
davidfowl added a commit that referenced this issue Jan 30, 2013
@davidfowl
Don't expose certain methods on hub methods.
99be864 
- Don't expose methods on object or events.
- Added unit tests.
#1443
@Xiaohongt
Copy link
Contributor

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidfowl davidfowl

Labels
security type: Bug
Projects
None yet
Milestone
1.0 RTW
Development

No branches or pull requests
3 participants
@davidfowl @DamianEdwards @Xiaohongt