📦 Remove internal packages from dependencies list #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuintonC
requested review from
jamiely,
Soleone,
caropinzonsilva,
lesliexin,
Borahm and
imjameshall
as code owners
jamiely
approved these changes
Mar 9, 2023
caropinzonsilva
approved these changes
Mar 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ What is the context for these changes?
Removes
tsconfigandsharedfrom package.json for@shopify/connect-wallet,@shopify/gate-context-client@shopify/tokengateto prevent them from being listed as dependencies on NPM (image below).🕹️ Demonstration
The goal is to remove
sharedandtsconfigfrom the list of dependencies on npmjs.Next.js test
Screen.Recording.2023-03-09.at.12.54.09.PM.mov
Vite test
Screen.Recording.2023-03-09.at.12.55.13.PM.mov
✅ Checklist
Tested on mobileN/ATested on multiple browsersN/ATested for accessibilityN/AIncludes unit testsN/AUpdated relevant documentation for the changes (if necessary)N/A