Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor solution .targets files, enable detailed ILC warnings #872

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Refactor solution .targets files, enable detailed ILC warnings #872

merged 4 commits into from
Nov 25, 2024

Conversation

Sergio0694
Copy link
Owner

Description

This PR includes two changes:

  • Moves the shared AOT props for the published projects to a "BeforeMicrosoftCommonTargets" file
    • This should ensure that things such as "IsAotCompatible" are set soon enough
  • Disables "TrimmerSingleWarn" for the whole solution, to get detailed ILCXXXX warnings

@Sergio0694 Sergio0694 added the maintenance ⚙️ Issues/PRs about maintenance/CI work label Nov 19, 2024
@Sergio0694 Sergio0694 force-pushed the dev/custom-beforecommon-targets branch 4 times, most recently from 89ec1a4 to b38629f Compare November 24, 2024 23:43
@Sergio0694 Sergio0694 force-pushed the dev/custom-beforecommon-targets branch from b38629f to fdbe652 Compare November 25, 2024 00:14
@Sergio0694 Sergio0694 merged commit 9aa98b3 into main Nov 25, 2024
24 checks passed
@Sergio0694 Sergio0694 deleted the dev/custom-beforecommon-targets branch November 25, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance ⚙️ Issues/PRs about maintenance/CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sergio0694