Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework linking analyzer, remove generator heuristic, change D2D compile options #811

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

Sergio0694
Copy link
Owner

Closes #804

Description

Take two from #807, with some more tweaks.

This PR includes changes around shader linking:

  • Updates the linking analyzer and repurposes it to warn for invalid trivial sampling options instead
  • Removes the heuristic automatically enabling shader linking only for shaders with simple inputs
  • Add shader linking to the Default preset
  • Also a new OptimizeForSize option to the D2D compile options

@Sergio0694 Sergio0694 added enhancement ✨ An improvement to existing APIs optimization 🚀 Performance improvement to existing APIs labels Jun 8, 2024
@Sergio0694 Sergio0694 requested a review from rickbrew June 8, 2024 02:19
@Sergio0694 Sergio0694 force-pushed the dev/shader-linking-fixes2 branch from 23b5879 to 2c36f2c Compare June 8, 2024 05:58
@Sergio0694 Sergio0694 merged commit a5cad31 into main Jun 8, 2024
24 checks passed
@Sergio0694 Sergio0694 deleted the dev/shader-linking-fixes2 branch June 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ An improvement to existing APIs optimization 🚀 Performance improvement to existing APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

D2D1 pixel shaders w/ complex inputs should still be compiled for linking
2 participants