Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic for invalid linking D2D compile option #638

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Sergio0694
Copy link
Owner

@Sergio0694 Sergio0694 commented Oct 22, 2023

Closes #462 (and contributes to #598)

Description

This PR adds a diagnostic (warning) when a D2D shader has the EnableLinking option set, but has any complex inputs.

@Sergio0694 Sergio0694 added the enhancement ✨ An improvement to existing APIs label Oct 22, 2023
@Sergio0694 Sergio0694 force-pushed the dev/d2d-compile-options-analyzer branch 2 times, most recently from 5f012d1 to 2f0dc11 Compare October 22, 2023 22:41
@Sergio0694 Sergio0694 force-pushed the dev/d2d-compile-options-analyzer branch from 2f0dc11 to fe0f68d Compare November 21, 2023 13:37
@Sergio0694 Sergio0694 merged commit c308993 into main Nov 21, 2023
24 checks passed
@Sergio0694 Sergio0694 deleted the dev/d2d-compile-options-analyzer branch November 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ An improvement to existing APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add diagnostic for invalid linking compile option
1 participant