Refactor global state for built-in pixel shader effects #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the internal
Foo<T>
type used by the built-in pixel shader effects, and switches that to use aGlobals
abstract class with all shader properties, and derivedGlobals<T>
class implementing all properties for each shader typeT
. The factory will now pass that instance, and the pixel shader effect will use aGCHandle
to resolveGlobals
instances and invoke members on it. This avoids the need to manually copy all properties from the shader at construction time, from the static constructor. Now they're all lazily initialized instead, as an additional bonus.