Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only declare valid resource texture manager properties in effect XML #586

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

Sergio0694
Copy link
Owner

Closes #562

Description

This PR updates the effect XML to only show the resource texture managers that are actually valid. It also introduces the explicit difference between the index of the resource texture manager, and the actual resource texture index, which may differ.

@Sergio0694 Sergio0694 added bug fix ✅ A fix for a reported/discovered bug optimization 🚀 Performance improvement to existing APIs breaking change 💣 A change that is either binary or source breaking labels Oct 1, 2023
@Sergio0694 Sergio0694 merged commit 4ab55e8 into main Oct 1, 2023
@Sergio0694 Sergio0694 deleted the dev/only-valid-xml-props branch October 1, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 💣 A change that is either binary or source breaking bug fix ✅ A fix for a reported/discovered bug optimization 🚀 Performance improvement to existing APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

D2D1PixelShaderEffect returns E_INVALIDARG for valid property indices
1 participant