Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch HLSL bytecode, shader profile and compile options to properties #577

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

Sergio0694
Copy link
Owner

Description

This PR updates the ID2D1Shader interface to use properties for the HLSL bytecode, shader profile and compile options:

namespace ComputeSharp.D2D1.__Internals;

public interface ID2D1Shader
{
    D2D1ShaderProfile ShaderProfile { get; }
    D2D1CompileOptions CompileOptions { get; }
    ReadOnlyMemory<byte> HlslBytecode { get; }
}

@Sergio0694 Sergio0694 added optimization 🚀 Performance improvement to existing APIs feature 🎉 A brand new feature for ComputeSharp breaking change 💣 A change that is either binary or source breaking labels Sep 28, 2023
@Sergio0694 Sergio0694 merged commit 4fa5a7c into main Sep 28, 2023
@Sergio0694 Sergio0694 deleted the dev/shader-bytecode-memory branch September 28, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 💣 A change that is either binary or source breaking feature 🎉 A brand new feature for ComputeSharp optimization 🚀 Performance improvement to existing APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant