Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reified generic instantiations in CLI sample #537

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

Sergio0694
Copy link
Owner

Descriptio

This PR makes the Win32Application non generic, and shared across all shaders.
Saves 45 KB on the x64 binary for NativeAOT (tested on .NET 7):

  • main: 1.484 KB
  • PR: 1.439 KB

@Sergio0694 Sergio0694 added the optimization 🚀 Performance improvement to existing APIs label Jun 26, 2023
@Sergio0694 Sergio0694 force-pushed the dev/remove-reified-generics-cli branch from 5d35bb4 to 12befc9 Compare June 26, 2023 00:14
@Sergio0694 Sergio0694 merged commit 8b44e72 into main Jun 26, 2023
@Sergio0694 Sergio0694 deleted the dev/remove-reified-generics-cli branch June 26, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization 🚀 Performance improvement to existing APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant