feat: support rational functions in HomotopyContinuationProblem
#3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| jac = true, eval_expression, eval_module) | ||
|
|
||
| denominator = MTK.build_explicit_observed_function(sys, denoms) |
There was a problem hiding this comment.
don't you just want the numerator?
There was a problem hiding this comment.
The denominator is used to rule out roots that cause a 0/0. A trivial example would be 0 ~ (x - y) / (x - 3), 0 ~ y - 3. If we take the numerators and solve, we get x = y = 3, but that causes 0 / 0 in the first polynomial and hence the system is actually infeasible.
AayushSabharwal
force-pushed
the
as/homotopy-rational-poly
branch
from
92da576 to
77ceea5
Compare
ChrisRackauckas
approved these changes
Oct 26, 2024
AayushSabharwal
force-pushed
the
as/homotopy-rational-poly
branch
from
77ceea5 to
7aae63d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SciML/SciMLBase.jl#829
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.