Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible handle leak #1494

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Fix possible handle leak #1494

merged 1 commit into from
Jan 5, 2025

Conversation

peter15914
Copy link
Contributor

Calls to fclose() were missing in some cases when goto error was used.
Therefore, I added fclose().
The check if (file) is needed, because goto error is also used when file was not successfully opened.

@peter15914 peter15914 marked this pull request as ready for review January 3, 2025 13:55
@SanderMertens
Copy link
Owner

LGTM, can you also update the flecs.c file in the distr folder? That's what is causing CI to fail.

@peter15914
Copy link
Contributor Author

LGTM, can you also update the flecs.c file in the distr folder? That's what is causing CI to fail.

Thanks for the review!
I updated flecs.c.

@SanderMertens
Copy link
Owner

Thanks for the PR!

@SanderMertens SanderMertens merged commit c8f6834 into SanderMertens:master Jan 5, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter15914 @SanderMertens