@W-17039090@ : [Server Affinity] - Attach dwsid to SCAPI request headers

[shethj]

Description

For a Phased Launch storefront, SCAPI requires each request to contain ECOM dwsid in sfdc_dwsid header with each request.
To allow PWA Kit to read dwsid from cookies we require the cookie to be set with httpOnly=false.
Plugin SLAS manually sets response cookies and has been setting dwsid with httpOnly=false
We can leverage that cookie to be used in PWA Kit to send with each SCAPI request.

Types of Changes

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Breaking change (could cause existing functionality to not work as expected)
• Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

• Removing a public function or component or prop
• Adding a required argument to a function
• Changing the data type of a function parameter or return value
• Adding a new peer dependency to package.json

Changes

• Added sfdc_dwsid header to all requests made in commerce-sdk-react
• Remove ocapi proxy from the retail app and generator templates

How to Test-Drive This PR

• Logon to prd2.phased-launch-testing.com
• Clear Site Data using DevTools
• Load Home Page
• Open Network Tab and confirm /sessions requests are not made
• Open Cookies and confirm dwsid is not being set
• Add item to cart and navigate to cart page
• Open cookies and verify dwsid is now set
• Navigate back to PWA Kit page
• Inspect any SCAPI request and confirm sfdc_dwsid exists in request headers

Local test run results:

Checklists

General

• Changes are covered by test cases
• CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

• There are no changes to UI

or...

• Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
• Changes comply with WCAG 2.0 guidelines levels A and AA
• Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

• Changes include a UI text update in the Retail React App (which requires translation)

[vcua-mobify]

It's good that we're removing the OCAPI sessions URL from the generated apps since we've removed it from template-retail-react-app already.

[vcua-mobify]

Should we modify the config files in template-retail-react-app and the generator to remove the OCAPI proxy?
I think our test mocks set up an OCAPI proxy mock that we'll need to clean up too.

[unandyala]

Should we modify the config files in template-retail-react-app and the generator to remove the OCAPI proxy? I think our test mocks set up an OCAPI proxy mock that we'll need to clean up too.

Is this the only url/api that uses ocapi?

[unandyala]

LGTM

[shethj]

Should we modify the config files in template-retail-react-app and the generator to remove the OCAPI proxy? I think our test mocks set up an OCAPI proxy mock that we'll need to clean up too.

Is this the only url/api that uses ocapi?

Yes. It was the only OCAPI call we were making.

[shethj]

@vcua-mobify @unandyala Great callouts about OCAPI proxy. I tried removing the proxy and ran tests on the deployed store. Looks good to me.

[vcua-mobify]

One more spot we might want to clean up: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/feature/server-affinity-cleanup/packages/pwa-kit-react-sdk/setup-jest.js#L35

[vcua-mobify]

This might be a separate clean up ticket but the generator prompts is for an instanceUrl that, according to a comment in the generator, is only used to set up the OCAPI proxy: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/feature/server-affinity-cleanup/packages/pwa-kit-create-app/scripts/create-mobify-app.js#L801

[shethj]

This might be a separate clean up ticket but the generator prompts is for an instanceUrl that, according to a comment in the generator, is only used to set up the OCAPI proxy: https://github.com/SalesforceCommerceCloud/pwa-kit/blob/feature/server-affinity-cleanup/packages/pwa-kit-create-app/scripts/create-mobify-app.js#L801

Yeah. I'm leaving all generator changes out of this PR. I'll have a follow up ticket for that since it involves testing and changes to tests as well. It'll blow up the scope of this one.

[vcua-mobify]

Thanks for all the changes! +1