Remove incorrect usage of @chakra-ui/layout #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinxh
added
the
skip changelog
adamraya
approved these changes
Oct 2, 2024
vmarta
reviewed
Oct 2, 2024
| @@ -5,9 +5,14 @@ | |||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | |||
| */ | |||
| import React, {useState, useEffect, useRef} from 'react' | |||
| import {Stack, Heading} from '@chakra-ui/layout' | |||
There was a problem hiding this comment.
If we want to make sure that the chakra imports go through our shared/ui thing, then there's another candidate here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove incorrect usage of @chakra-ui/layout , this breaks generated projects.
Why did it break NOW?
My guess is that in the
@chakra-ui/reactincluded the@chakra-ui/layoutpackage as a transient dependencies that even if retail-react-app don't install it, it worked fine. I suspect the recent releases of@chakra-ui/reactpackage removed the dependency and caused the issue.