@W-16660178@ Small bug fixes #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfeister
reviewed
Sep 10, 2024
Comment on lines
55
to
53
| onClick={() => history.push('/')} | ||
| onClick={() => (window.location.href = '/')} |
There was a problem hiding this comment.
So that I understand clearly -- the idea here is that the application is in an error state from a JavaScript perspective, so in some sense "React has crashed" so the window.history listener in React doesn't pick up the change so we just hard navigate?
There was a problem hiding this comment.
Yes, that's correct. If we use history, we trigger a soft navigation and are still in an error state so the home page is not rendered. We need to trigger a hard navigate to get out of the error state.
alexvuong
reviewed
Sep 10, 2024
alexvuong
previously approved these changes
Sep 10, 2024
|
Left a small comment, the rest looks good. Thanks for working on these issues. 👍 |
vcua-mobify
dismissed stale reviews from alexvuong and bfeister
via
9bd4120
alexvuong
approved these changes
Sep 10, 2024
bfeister
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bugs reported in #1946 and #1941
Testing:
For #1946 (Default product-scroller skips tiles (desktop)),
Start the app on the home page then scroll down to the recommended product scroller. Scroll the products and make sure no tiles are skipped
Before:
Screen.Recording.2024-09-09.at.3.47.18.PM.mov
After:
Screen.Recording.2024-09-09.at.3.54.26.PM.mov
For #1941 (Error handling issues)
PDP / PLP error handling:
Make the app throw a non 404 error and verify that the error page is rendered.
(I just commented out the HTTP 404 case so that the default HTTPError constructor is called when I render a 404)
Navigating back to the home page from error page
Once on the error page, click the Salesforce cloud icon to navigate back to home. Ensure that the home page renders.
Before:
Screen.Recording.2024-09-09.at.4.10.15.PM.mov
After:
Screen.Recording.2024-09-09.at.4.47.10.PM.mov