-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-15714251: Show badges on product tile #1791
Merged
unandyala
merged 22 commits into
v3/product-tile-revamp
from
unandyala.W-15714251.product-badges
May 22, 2024
Merged
@W-15714251: Show badges on product tile #1791
unandyala
merged 22 commits into
v3/product-tile-revamp
from
unandyala.W-15714251.product-badges
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinxh
reviewed
May 16, 2024
packages/template-retail-react-app/app/components/badge-group/index.jsx
Outdated
Show resolved
Hide resolved
kevinxh
reviewed
May 16, 2024
packages/template-retail-react-app/app/components/badge-group/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
May 16, 2024
echessman
reviewed
May 16, 2024
packages/pwa-kit-create-app/assets/bootstrap/js/package.json.hbs
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
May 16, 2024
packages/template-retail-react-app/app/components/badge-group/index.jsx
Outdated
Show resolved
Hide resolved
bendvc
reviewed
May 17, 2024
packages/template-retail-react-app/app/components/badge-group/index.jsx
Outdated
Show resolved
Hide resolved
bendvc
reviewed
May 17, 2024
packages/template-retail-react-app/app/components/badge-group/index.jsx
Outdated
Show resolved
Hide resolved
bendvc
reviewed
May 17, 2024
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
kevinxh
reviewed
May 17, 2024
alexvuong
reviewed
May 21, 2024
vmarta
reviewed
May 21, 2024
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
May 21, 2024
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
May 21, 2024
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
vmarta
reviewed
May 21, 2024
packages/template-retail-react-app/app/components/product-tile/index.test.js
Outdated
Show resolved
Hide resolved
bendvc
reviewed
May 21, 2024
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
May 21, 2024
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
vmarta
approved these changes
May 22, 2024
bendvc
reviewed
May 22, 2024
packages/template-retail-react-app/app/components/product-tile/index.jsx
Outdated
Show resolved
Hide resolved
bendvc
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance product tile to show product badges.
Badges are shown based on the product custom properties. Default/out-of-the-box badges that are available are
New
andSale
which are based on the custom propertiesc_isSale
andc_isNew
Users can also pass other boolean custom properties to display as badges. For example we can add a new custom property
isCloseout
and pass it as abadgeLabels
to theProductTile
component. (Example:<ProductTile badgeLabels={[{label: 'Closeout', color: 'red'}]}
)BadgeGroup (it is a group because more than one badge can be displayed) is built as a separate component. It includes all the required data as properties (including product). The intention is that it makes it easy for users to override/extend the implementation
Types of Changes
Changes
Render badges on product tile based on the product custom attributes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization